Conversation
This is an extension of work carried out by hpbuniat. The rule he submitted did not work if there was a null before :hover. This rule tests for the IE7/IE8 issue where un-anchored hovers cause poor performance
Test case
|
This looks good, can you add documentation on the wiki in the rules section? |
|
Hi, Would you like me to also make the same updates to with wiki in stubbornella / csslint? |
|
Yes, please. I like this rule. Let's try to get it into the next version. On Thu, Jun 6, 2013 at 1:57 AM, niallmur notifications@github.com wrote:
|
non-link-hover
Outdated
There was a problem hiding this comment.
updated affected browsers to IE7, IE8
|
Overall, this looks great, just a couple things to clean up. Thanks! |
Updated comments and affected browsers
|
Hi Nicole, I have made all the changes you asked for. I have however managed to kick off a merge to 'duplicate property value Thanks Niall On Wed, Jun 12, 2013 at 8:12 AM, Nicole Sullivan
|
…this is against convention this is still valid css and wll prevent the :hover performance issue
|
Can you clean up the branch? Rebase, squash etc. |
This is an extension to work already carried out by hpbuniat.
#116
However the rule he submitted did not work correctly and threw parser errors when there was a null before :hover
This basic check below threw a cant read a null from text error.
div.test :hover{
}
This rule is important because it can cause very severe performance issues in IE7 if :hover is used and un-anchored.
(bug report about un-anchored hovers in IE7 and IE8)
https://developers.google.com/speed/docs/best-practices/rendering
http://msdn.microsoft.com/en-us/library/ie/cc848866%28v=vs.85%29.aspx